lkml.org 
[lkml]   [2018]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH REGRESSION] Revert "ath10k: add quiet mode support for QCA6174/QCA9377"
On 2018-11-08 03:00, Rajkumar Manoharan wrote:
> On 2018-11-07 10:56, Brian Norris wrote:
>> This reverts commit cfb353c0dc058bc1619cc226d3cbbda1f360bdd3.
>>
>> WCN3990 firmware does not yet implement this feature, and so it
>> crashes
>> like this:
>>
>> fatal error received: err_qdi.c:456:EX:wlan_process:1:WLAN
>> RT:207a:PC=b001b4f0
>>
>> This feature can be re-implemented with a proper service bitmap or
>> other
>> feature-discovery mechanism in the future. But it should not break
>> working boards.
>>
> Brian,
>
> The change "ath10k: add quiet mode support for QCA6174/QCA9377" was
> merged even
> before full WCN3990 device support was added in ath10k. How come it
> could be regression
> for WCN3990. I know both are sharing same WMI-TLV interface but
> reverting this
> will break QCA6174/QCA9377. no?
>

This regression is found while we switched from 4.18 + WCN3990
back-ports to 4.19.

> I would prefer to handle this within WMI callback or upper layer.
>

IMO, we should use (WMI_SERVICE_THERMAL_MGMT | WMI_SERVICE_THERM_THROT )
service bitmap check and call
ath10k_thermal_set_throttling only if fw supports THERMAL THROTTLE
feature. But we need to ensure all
available ath10k fw's are reporting this service.

> -Rajkumar

BR,
Govind

\
 
 \ /
  Last update: 2018-11-08 05:33    [W:0.156 / U:29.732 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site