lkml.org 
[lkml]   [2018]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH V2] binder: ipc namespace support for android binder
Date
> -----Original Message-----
> From: Andrew Morton <akpm@linux-foundation.org>
> Sent: Thursday, November 8, 2018 6:38 AM
> To: chouryzhou(周威) <chouryzhou@tencent.com>
> Cc: gregkh@linuxfoundation.org; arve@android.com; tkjos@android.com;
> dave@stgolabs.net; devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH V2] binder: ipc namespace support for android
> binder
>
> On Wed, 7 Nov 2018 01:48:12 +0000 chouryzhou(周威)
> <chouryzhou@tencent.com> wrote:
>
> > > > --- a/ipc/namespace.c
> > > > +++ b/ipc/namespace.c
> > > > @@ -56,6 +56,9 @@ static struct ipc_namespace *create_ipc_ns(struct
> > > user_namespace *user_ns,
> > > > ns->ucounts = ucounts;
> > > >
> > > > err = mq_init_ns(ns);
> > > > + if (err)
> > > > + goto fail_put;
> > > > + err = binder_init_ns(ns);
> > > > if (err)
> > > > goto fail_put;
> > > >
> > >
> > > Don't we need an mq_put_mnt() if binder_init_ns() fails?
> > >
> > > free_ipc_ns() seems to have forgotten about that too. In which case it
> > > must be madly leaking mounts so probably I'm wrong. Confused.
> > >
> >
> > mq_init_ns will do clean job if it failed, and as do binder_init_ns.
>
> My point is that if mq_init_ns() succeeds and binder_init_ns() fails,
> we don't undo the effects of mq_init_ns()?

Oh, mq_put_mnt is called in put_ipc_ns. We should invoke put_ipc_ns if binder_init_ns fails. I will update the patch soon. Thank you very much for pointing out the issue.
\
 
 \ /
  Last update: 2018-11-08 04:02    [W:0.030 / U:0.668 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site