lkml.org 
[lkml]   [2018]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] ARM: dts: imx7d-sdb: add rev-a board support
Date
Hi, Fabio

Best Regards!
Anson Huang

> -----Original Message-----
> From: Fabio Estevam [mailto:festevam@gmail.com]
> Sent: 2018年11月7日 18:03
> To: Anson Huang <anson.huang@nxp.com>
> Cc: Rob Herring <robh+dt@kernel.org>; Mark Rutland
> <mark.rutland@arm.com>; Shawn Guo <shawnguo@kernel.org>; Sascha
> Hauer <s.hauer@pengutronix.de>; Sascha Hauer <kernel@pengutronix.de>;
> Fabio Estevam <fabio.estevam@nxp.com>; open list:OPEN FIRMWARE AND
> FLATTENED DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; linux-kernel
> <linux-kernel@vger.kernel.org>; moderated list:ARM/FREESCALE IMX / MXC
> ARM ARCHITECTURE <linux-arm-kernel@lists.infradead.org>; dl-linux-imx
> <linux-imx@nxp.com>
> Subject: Re: [PATCH] ARM: dts: imx7d-sdb: add rev-a board support
>
> Hi Anson,
>
> On Wed, Nov 7, 2018 at 3:19 AM Anson Huang <anson.huang@nxp.com>
> wrote:
>
> > +&fec2 {
> > + pinctrl-0 = <&pinctrl_enet2>;
> > + /delete-property/pinctrl-assert-gpios;
>
> "pinctrl-assert-gpios" does not exist in mainline, so not sure why you are
> deleting it.

Regarding the fec2 settings in imx7d-sdb.dts, originally it uses Rev-A board (but some nodes are
using Rev-B board), in this patch, I clean up all the settings in imx7d-sdb.dts using Rev-B board,
so below is added to imx7d-sdb.dts for Rev-B board, and in imx7d-sdb-reva.dts I have to
delete it, since Rev-A board has no this pin.

- pinctrl-0 = <&pinctrl_enet2>;
+ pinctrl-0 = <&pinctrl_enet2 &pinctrl_enet2_epdc0_en>;
+ pinctrl-assert-gpios = <&gpio1 4 GPIO_ACTIVE_LOW>;

Anson.

\
 
 \ /
  Last update: 2018-11-08 02:25    [W:0.106 / U:2.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site