lkml.org 
[lkml]   [2018]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 6/6] tpm: ensure that the output of PCR read contains the correct digest size
On Thu, Nov 08, 2018 at 03:47:39PM +0100, Roberto Sassu wrote:
> > > + for (i = 0; i < chip->nr_active_banks &&
> > > + chip->active_banks[i].alg_id != digest_struct->alg_id; i++)
> > > + ;
> >
> > Not sure if the semicolon should be in its own line.
>
> scripts/Lindent suggests:
>
> for (i = 0; i < chip->nr_active_banks &&
> chip->active_banks[i].alg_id != digest_struct->alg_id;
> i++) ;
>
> but this is not accepted by scripts/checkpatch.pl (there are no
> warnings/errors on the patch I sent).

Yeah, not a really blocker for me.

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

/Jarkko

\
 
 \ /
  Last update: 2018-11-08 19:53    [W:0.545 / U:3.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site