lkml.org 
[lkml]   [2018]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 04/24] dt-bindings: leds: Add function and color properties
From
Date
Jacek

On 11/06/2018 04:07 PM, Jacek Anaszewski wrote:
> Introduce dedicated properties for conveying information about
> LED function and color. Mark old "label" property as deprecated.
>
> Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Cc: Baolin Wang <baolin.wang@linaro.org>
> Cc: Daniel Mack <daniel@zonque.org>
> Cc: Dan Murphy <dmurphy@ti.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Oleh Kravchenko <oleg@kaa.org.ua>
> Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
> Cc: Simon Shields <simon@lineageos.org>
> Cc: Xiaotong Lu <xiaotong.lu@spreadtrum.com>
> ---
> Documentation/devicetree/bindings/leds/common.txt | 52 +++++++++++++++++++----
> 1 file changed, 44 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt
> index aa13998..3efc826 100644
> --- a/Documentation/devicetree/bindings/leds/common.txt
> +++ b/Documentation/devicetree/bindings/leds/common.txt
> @@ -10,14 +10,20 @@ can influence the way of the LED device initialization, the LED components
> have to be tightly coupled with the LED device binding. They are represented
> by child nodes of the parent LED device binding.
>
> +
> Optional properties for child nodes:
> - led-sources : List of device current outputs the LED is connected to. The
> outputs are identified by the numbers that must be defined
> in the LED device binding documentation.
> +- function: LED functon. Use one of the LED_FUNCTION_* prefixed definitions
> + from the header include/dt-bindings/leds/functions.h.
> + If there is no matching LED_FUNCTION available, add a new one.
> +- color : Color of the LED.

Should we define the colors too? There are only really 4. Red, green, blue and white.

Generally varying colors are created base on the primary colors. Even the amber color

Dan

> - label : The label for this LED. If omitted, the label is taken from the node
> name (excluding the unit address). It has to uniquely identify
> a device, i.e. no other LED class device can be assigned the same
> - label.
> + label. This property is deprecated - use 'function' and 'color'
> + properties instead.
>
> - default-state : The initial state of the LED. Valid values are "on", "off",
> and "keep". If the LED is already on or off and the default-state property is
> @@ -87,29 +93,59 @@ Required properties for trigger source:
>
> * Examples
>
> -gpio-leds {
> +#include <dt-bindings/leds/functions.h>
> +
> +led-controller@0 {
> compatible = "gpio-leds";
>
> - system-status {
> - label = "Status";
> + led0 {
> + function = LED_FUNCTION_STATUS;
> linux,default-trigger = "heartbeat";
> gpios = <&gpio0 0 GPIO_ACTIVE_HIGH>;
> };
>
> - usb {
> + led1 {
> + function = LED_FUNCTION_USB;
> gpios = <&gpio0 1 GPIO_ACTIVE_HIGH>;
> trigger-sources = <&ohci_port1>, <&ehci_port1>;
> };
> };
>
> -max77693-led {
> +led-controller@0 {
> compatible = "maxim,max77693-led";
>
> - camera-flash {
> - label = "Flash";
> + led {
> + function = LED_FUNCTION_FLASH;
> + color = "white";
> led-sources = <0>, <1>;
> led-max-microamp = <50000>;
> flash-max-microamp = <320000>;
> flash-max-timeout-us = <500000>;
> };
> };
> +
> +led-controller@68 {
> + compatible = "ti,tlc59116";
> + reg = <0x68>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + led@0 {
> + function = LED_FUNCTION_WAN;
> + color = "amber";
> + reg = <0x0>;
> + };
> +
> + led@2 {
> + function = LED_FUNCTION_2G;
> + color = "white";
> + reg = <0x2>;
> + };
> +
> + led@9 {
> + function = LED_FUNCTION_ALIVE;
> + color = "green";
> + reg = <0x9>;
> + linux,default_trigger = "heartbeat";
> + };
> +};
>


--
------------------
Dan Murphy

\
 
 \ /
  Last update: 2018-11-08 19:01    [W:0.632 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site