lkml.org 
[lkml]   [2018]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [RFC PATCH 10/12] soc: qcom: ipa: data path
On Wed, Nov 7, 2018 at 1:33 AM Alex Elder <elder@linaro.org> wrote:
>
> This patch contains "ipa_dp.c", which includes the bulk of the data
> path code. There is an overview in the code of how things operate,
> but there are already plans to rework this portion of the driver.
>
> In particular:
> - Interrupt handling will be replaced with a threaded interrupt
> handler. Currently handling occurs in a combination of
> interrupt and workqueue context, and this requires locking
> and atomic operations for proper synchronization.

You probably don't want to use just a threaded IRQ handler to
start the poll function, that would still require an extra indirection.

However, you can probably use the top half of the threaded
handler to request the poll function if necessary but use
the bottom half for anything that does not go through poll.

> - Currently, only receive endpoints use NAPI. Transmit
> completion interrupts are disabled, and are handled in batches
> by periodically scheduling an interrupting no-op request.
> The plan is to arrange for transmit requests to generate
> interrupts, and their completion will be processed with other
> completions in the NAPI poll function. This will also allow
> accurate feedback about packet sojourn time to be provided to
> queue limiting mechanisms.

Right, that is definitely required here. I also had a look at
the gsi_channel_queue() function, which sits in the middle of
the transmit function and is rather unoptimized. I'd suggest moving
that into the caller so we can see what is going on, and then
optimizing it from there.

> - Not all receive endpoints use NAPI. The plan is for *all*
> endpoints to use NAPI. And because all endpoints share a
> common GSI interrupt, a single NAPI structure will used to
> managing the processing for all completions on all endpoints.
> - Receive buffers are posted to the hardware by a workqueue
> function. Instead, the plan is to have this done by the
> NAPI poll routine.

Makes sense, yes.

Arnd

\
 
 \ /
  Last update: 2018-11-07 15:56    [W:0.317 / U:1.800 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site