[lkml]   [2018]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRE: [PATCH v4 06/12] iommu/vt-d: Add second level page table interface
Hi Baolu,

> From: Lu Baolu []
> Sent: Monday, November 5, 2018 1:32 PM
> This adds the interfaces to setup or tear down the structures
> for second level page table translations. This includes types
> of second level only translation and pass through.

A little bit refining to the description:)
"This patch adds interfaces for setup or tear down second level
translation in PASID granularity. Translation type includes second
level only type and pass-through type."

> Cc: Ashok Raj <>
> Cc: Jacob Pan <>
> Cc: Kevin Tian <>
> Cc: Liu Yi L <>
> Signed-off-by: Sanjay Kumar <>


> +
> +void intel_pasid_tear_down_entry(struct intel_iommu *iommu,
> + struct device *dev, int pasid)
> +{
> + struct pasid_entry *pte;

pte is confusing as it is similar with pte in paging structures. may use
pt_entry or just pasid_entry. This comment applies to other "pte"s in
this patch.

Yi Liu

 \ /
  Last update: 2018-11-07 08:15    [W:0.163 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site