lkml.org 
[lkml]   [2018]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v15 14/23] x86/cpu/intel: Clear SGX_LC capability if not enabled in FEATURE_CONTROL
On Sat, Nov 03, 2018 at 03:15:15PM +0200, Andy Shevchenko wrote:
> > @@ -618,6 +618,8 @@ static void detect_sgx(struct cpuinfo_x86 *c)
> > setup_clear_cpu_cap(X86_FEATURE_SGX1);
> > setup_clear_cpu_cap(X86_FEATURE_SGX2);
> > }
> > + if (unsupported || !(fc & FEATURE_CONTROL_SGX_LE_WR))
> > + setup_clear_cpu_cap(X86_FEATURE_SGX_LC);
> > }
>
> A-ha, I see how you use this variable here (though it's still possible
> to get rid of it, choose what is better for readability /
> maintenance).

I would propose to squash this one to the earlier commit and refactor
it in a way that I proposed. Having this part as a separate commit in
my opinion is a bit confusing.

/Jarkko

\
 
 \ /
  Last update: 2018-11-05 15:38    [W:0.081 / U:1.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site