lkml.org 
[lkml]   [2018]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] crypto: mark cts(cbc(aes)) as FIPS allowed
Date
Am Montag, 5. November 2018, 11:20:28 CET schrieb Ard Biesheuvel:

Hi Ard, Gilad,

> On 5 November 2018 at 10:18, Gilad Ben-Yossef <gilad@benyossef.com> wrote:
> > Hi Stephan,
> >
> > On Mon, Nov 5, 2018 at 10:50 AM Stephan Mueller <smueller@chronox.de>
wrote:
> >> Am Sonntag, 4. November 2018, 11:05:24 CET schrieb Gilad Ben-Yossef:
> >>
> >> Hi Gilad,
> >>
> >> > As per Sp800-38A addendum from Oct 2010[1], cts(cbc(aes)) is
> >> > allowed as a FIPS mode algorithm. Mark it as such.
> >> >
> >> > [1] https://csrc.nist.gov/publications/detail/sp/800-38a/addendum/final
> >>
> >> There are several types of CTS approaches. Only three of those are listed
> >> in the SP800-38A addendum. The source code only refers to some RFCs.
> >>
> >> Did you check whether the CTS implementation matches one or more of the
> >> types listed in the addendum? If yes, may I suggest to add a small
> >> statement in the code noting this fact?
> >
> > Yes, AFAIK the software implements CBC-CS3 as described in the document.
> > You have a very good point about this not document anywhere. I will
> > send a patch.
>
> I agree that it makes sense to document this.

Thanks for adding this. With this statement, the initial patch of adding the
fips_allowed flag is:

Reviewed-by: Stephan Mueller <smueller@chronox.de>

Ciao
Stephan


\
 
 \ /
  Last update: 2018-11-05 11:31    [W:0.045 / U:2.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site