lkml.org 
[lkml]   [2018]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] drm/virtio: add virtio_gpu_alloc_fence()
> > On Thu, 25 Oct 2018 at 19:38, Robert Foss <robert.foss@collabora.com> wrote:
> > >
> > > From: Gustavo Padovan <gustavo.padovan@collabora.com>
> > >
> > > Refactor fence creation to remove the potential allocation failure from
> > > the cmd_submit and atomic_commit paths. Now the fence should be allocated
> > > first and just after we should proceed with the rest of the execution.
> > >
> >
> > Commit does a bit more that what the above says:
> > - dummy, factor out fence creation/destruction
> > - use per virtio_gpu_framebuffer fence
> >
> > Personally I'd keep the two separate patches and elaborate on the latter.
> > Obviously in that case, one will need to add 3 lines worth of
> > virtio_gpu_fence_alloc() in virtio_gpu_cursor_plane_update which will be nuked
> > with the next patch.
> >
> > Not a big deal, but it's up-to the maintainer to make the final call if it's
> > worth splitting or not.
>
> Agreed, I'll hold off with this change until then.

No need to split this, but a bit more verbose commit message would be
good.

cheers,
Gerd

\
 
 \ /
  Last update: 2018-11-05 07:39    [W:0.041 / U:2.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site