lkml.org 
[lkml]   [2018]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 0/2] i8253: Fix PIT shutdown quirk on Hyper-V
Date
From: Thomas Gleixner <tglx@linutronix.de>  Sent: Saturday, November 3, 2018 10:22 AM
>
> > Did you consider using a static_key instead? You could set it in
> > ms_hyperv_init_platform(). This would enable you to support future
> > Hyper-V versions which don't require avoiding to set the count to zero.
>
> Duh. Now that you say it it's more than obvious. Instead of checking for
> running on hyperv have a quirk check in that function and set it from
> hyperv. Not necessarily a static key required as this is not a fast path,
> so a simple ro_after_init marked variable is good enough
>
> Michael, sorry for guiding you down the wrong road. Juergens idea is much
> better.

Thanks. Will send a new patch set shortly.

>
> If you redo that, could you please make sure, that your mail series is
> properly threaded? i.e. the 1..n/n mails contain a
>
> Reference: <message_id_of_0/n>
>
Argh. Caused by a one-time foul up. I'll make sure not to do that again.

Michael

\
 
 \ /
  Last update: 2018-11-04 04:41    [W:0.080 / U:1.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site