lkml.org 
[lkml]   [2018]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v3] genirq/matrix: Choose CPU for managed IRQs based on how many of them are allocated
Date
> Subject: Re: [PATCH v3] genirq/matrix: Choose CPU for managed IRQs based
> on how many of them are allocated
>
> On Sat, 3 Nov 2018, Thomas Gleixner wrote:
> > On Fri, 2 Nov 2018, Long Li wrote:
> > > /**
> > > * irq_matrix_assign_system - Assign system wide entry in the matrix
> > > * @m: Matrix pointer
> > > @@ -269,7 +291,7 @@ int irq_matrix_alloc_managed(struct irq_matrix
> *m, const struct cpumask *msk,
> > > if (cpumask_empty(msk))
> > > return -EINVAL;
> > >
> > > - cpu = matrix_find_best_cpu(m, msk);
> > > + cpu = matrix_find_best_cpu_managed(m, msk);
> > > if (cpu == UINT_MAX)
> > > return -ENOSPC;
> > >
> > > @@ -282,6 +304,7 @@ int irq_matrix_alloc_managed(struct irq_matrix
> *m, const struct cpumask *msk,
> > > return -ENOSPC;
> > > set_bit(bit, cm->alloc_map);
> > > cm->allocated++;
> > > + cm->managed_allocated++;
> > > m->total_allocated++;
> > > *mapped_cpu = cpu;
> > > trace_irq_matrix_alloc_managed(bit, cpu, m, cm);
> >
> > so far so good. But what exactly decrements managed_allocated ?
>
> Another thing. If we add that counter, then it would be good to expose it in
> the debugfs files as well.

I will send an update to address those.

Long

>
> Thanks,
>
> tglx

\
 
 \ /
  Last update: 2018-11-04 00:55    [W:0.034 / U:0.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site