lkml.org 
[lkml]   [2018]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86, olpc: Indicate that legacy PC platform should not register RTC
On Thu 2018-10-04 18:08:08, Lubomir Rintel wrote:
> On OLPC XO-1 we're discovering the RTC via device tree from the arch
> initcall. Don't let the PC platform register another one from its
> device initcall, it's not going to work:
>
> sysfs: cannot create duplicate filename '/devices/platform/rtc_cmos'
> CPU: 0 PID: 1 Comm: swapper Not tainted 4.19.0-rc6 #12
> Hardware name: OLPC XO/XO, BIOS OLPC Ver 1.00.01 06/11/2014
> Call Trace:
> dump_stack+0x16/0x18
> sysfs_warn_dup+0x46/0x58
> sysfs_create_dir_ns+0x76/0x9b
> kobject_add_internal+0xed/0x209
> ? __schedule+0x3fa/0x447
> kobject_add+0x5b/0x66
> device_add+0x298/0x535
> ? insert_resource_conflict+0x2a/0x3e
> platform_device_add+0x14d/0x192
> ? io_delay_init+0x19/0x19
> platform_device_register+0x1c/0x1f
> add_rtc_cmos+0x16/0x31
> do_one_initcall+0x78/0x14a
> ? do_early_param+0x75/0x75
> kernel_init_freeable+0x152/0x1e0
> ? rest_init+0xa2/0xa2
> kernel_init+0x8/0xd5
> ret_from_fork+0x2e/0x38
> kobject_add_internal failed for rtc_cmos with -EEXIST, don't try to
> register things with the same name in the same directory.
> platform rtc_cmos: registered platform RTC device (no PNP device found)
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>

Acked-by: Pavel Machek <pavel@ucw.cz>


--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-11-04 12:29    [W:0.117 / U:4.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site