lkml.org 
[lkml]   [2018]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 7/7] lib/lzo: separate lzo-rle from lzo
Date
On 29/11/2018 4:43 am, Sergey Senozhatsky wrote:
> On (11/27/18 16:19), Dave Rodgman wrote:>
>> +static struct crypto_alg alg = {
>> + .cra_name = "lzo-rle",
>> + .cra_flags = CRYPTO_ALG_TYPE_COMPRESS,
>> + .cra_ctxsize = sizeof(struct lzorle_ctx),
>> + .cra_module = THIS_MODULE,
>> + .cra_init = lzorle_init,
>> + .cra_exit = lzorle_exit,
>> + .cra_u = { .compress = {
>> + .coa_compress = lzorle_compress,
>> + .coa_decompress = lzorle_decompress } }
>> +};
>
> A nitpick:
> indentation for .compress assignment is a bit confusing, maybe.

Looking a bit more closely, these structs are formatted fairly
inconsistently in the crypto directory. So, lzo-rle is consistent with
what lzo does... but various other files do it differently.

I'm happy to submit a whitespace cleanup patch if people would like, and
get everything in that directory consistent (i.e. adopt a style similar
to the example below)?

static struct scomp_alg scomp = {
.alloc_ctx = lzorle_alloc_ctx,
.free_ctx = lzorle_free_ctx,
.compress = lzorle_scompress,
.decompress = lzorle_sdecompress,
.base = {
.cra_name = "lzo-rle",
.cra_driver_name = "lzo-rle-scomp",
.cra_module = THIS_MODULE,
}
};

Dave
\
 
 \ /
  Last update: 2018-11-30 11:45    [W:0.150 / U:4.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site