lkml.org 
[lkml]   [2018]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/13] blkcg: associate blkg when associating a device
> diff --git a/include/linux/bio.h b/include/linux/bio.h
> index 62715a5a4f32..8bc9d9b29fd3 100644
> --- a/include/linux/bio.h
> +++ b/include/linux/bio.h
> @@ -486,6 +486,12 @@ extern unsigned int bvec_nr_vecs(unsigned short idx);
> extern const char *bio_devname(struct bio *bio, char *buffer);
>
> #define bio_set_dev(bio, bdev) \
> +do { \
> + bio_set_dev_only(bio, bdev); \
> + bio_associate_blkg(bio); \
> +} while (0)
> +
> +#define bio_set_dev_only(bio, bdev) \

This lacks any explanation on when you would use bio_set_dev_only or
bio_set_dev. Please document why we need both and why you'd choose or
the other.

\
 
 \ /
  Last update: 2018-11-30 10:55    [W:0.155 / U:9.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site