lkml.org 
[lkml]   [2018]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC 4/5] gnss: sirf: add a separate supply for a lna
On Fri 2018-11-30 07:38:04, Andreas Kemnade wrote:
> Hi,
>
> On Tue, 27 Nov 2018 19:03:57 +0100
> Pavel Machek <pavel@ucw.cz> wrote:
>
> > Hi!
> >
> > > Devices might have a separate lna between antenna output of the gps
> > > chip and the antenna which might have a separate supply
> >
> > Might have.
> >
> > > @@ -340,6 +349,12 @@ static int sirf_probe(struct serdev_device *serdev)
> > > goto err_put_device;
> > > }
> > >
> > > + data->lna = devm_regulator_get(dev, "lna");
> > > + if (IS_ERR(data->lna)) {
> > > + ret = PTR_ERR(data->lna);
> > > + goto err_put_device;
> > > + }
> > > +
> >
> > But it is not optional in the code. Probably should be?
>
> well, if it no lna regulator is defined in the dtb, the regulator
> framework will return a dummy

Aha, did not know that detail. It is ok, then...

> would not do that and would require more error checking in the code.
> But if there is some rule which says that devm_regulator_get_optional()
> should be used here, I can of course change that.
> Before sending a v2, is that the only issue here?

Quick look did not reveal anything else.

Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-11-30 09:44    [W:0.047 / U:0.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site