lkml.org 
[lkml]   [2018]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH v1 0/4] phy: qcom-qmp: Fix clock-cells binding and provider
Date
This series fixes the QMP PHY bindings, which had specified #clock-cells
in the parent node, and had set it to 1. Putting it in the parent node is
wrong because the clock providers are the child nodes, so this change
moves it there. Having it set to 1 is also wrong, since nothing is ever
specified as to what should go in that cell. So this changes it to zero.
Finally, this change completes a little bit of code to actually allow these
exposed clocks to be pointed at in DT.

I had no idea how to fix up ipq8074.dtsi. It seems to be completely wrong in
that it doesn't specify #clock-cells at all, has no child nodes, and
specifies clock-output-names in the parent node. As far as I can tell this
doesn't work at all. But I can't add the child nodes myself because I don't know
1) how many there are, and 2) the registers in them. I also have no way to test it.

Speaking of testing, I was able to test this on sdm845, but haven't tested msm8996.

This patch sits atop the UFS device nodes series [1].

[1] https://lore.kernel.org/lkml/20181026173544.136037-1-evgreen@chromium.org/



Evan Green (4):
dt-bindings: phy-qcom-qmp: Move #clock-cells to child
arm64: dts: qcom: msm8996: Fix QMP PHY #clock-cells
arm64: dts: qcom: sdm845: Fix QMP PHY #clock-cells
phy: qcom-qmp: Expose provided clocks to DT

.../devicetree/bindings/phy/qcom-qmp-phy.txt | 11 ++++-----
arch/arm64/boot/dts/qcom/msm8996.dtsi | 6 +++--
arch/arm64/boot/dts/qcom/sdm845.dtsi | 4 ++--
drivers/phy/qualcomm/phy-qcom-qmp.c | 23 ++++++++++++++++++-
4 files changed, 33 insertions(+), 11 deletions(-)

--
2.18.1

\
 
 \ /
  Last update: 2018-11-29 23:15    [W:0.193 / U:2.988 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site