lkml.org 
[lkml]   [2018]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/2] remoteproc: replace bool from struct rproc by u8
    Date
    Post [1] and checkpatch tool indicate that usage of bool type
    in structure is now no more allowed/advised.
    This patch replaces bool by unsigned char (u8) and reorders
    struct rproc fields to avoid padding.

    [1] https://lkml.org/lkml/2017/11/21/384

    Signed-off-by: Loic Pallardy <loic.pallardy@st.com>
    ---
    include/linux/remoteproc.h | 12 ++++++------
    1 file changed, 6 insertions(+), 6 deletions(-)

    diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h
    index 507a2b524208..b6660088949f 100644
    --- a/include/linux/remoteproc.h
    +++ b/include/linux/remoteproc.h
    @@ -452,15 +452,15 @@ struct rproc_dump_segment {
    * @index: index of this rproc device
    * @crash_handler: workqueue for handling a crash
    * @crash_cnt: crash counter
    - * @recovery_disabled: flag that state if recovery was disabled
    * @max_notifyid: largest allocated notify id.
    * @table_ptr: pointer to the resource table in effect
    * @cached_table: copy of the resource table
    * @table_sz: size of @cached_table
    - * @has_iommu: flag to indicate if remote processor is behind an MMU
    - * @auto_boot: flag to indicate if remote processor should be auto-started
    * @dump_segments: list of segments in the firmware
    * @nb_vdev: number of vdev currently handled by rproc
    + * @recovery_disabled: flag that state if recovery was disabled
    + * @has_iommu: flag to indicate if remote processor is behind an MMU
    + * @auto_boot: flag to indicate if remote processor should be auto-started
    */
    struct rproc {
    struct list_head node;
    @@ -485,15 +485,15 @@ struct rproc {
    int index;
    struct work_struct crash_handler;
    unsigned int crash_cnt;
    - bool recovery_disabled;
    int max_notifyid;
    struct resource_table *table_ptr;
    struct resource_table *cached_table;
    size_t table_sz;
    - bool has_iommu;
    - bool auto_boot;
    struct list_head dump_segments;
    int nb_vdev;
    + u8 recovery_disabled;
    + u8 has_iommu;
    + u8 auto_boot;
    };

    /**
    --
    2.7.4
    \
     
     \ /
      Last update: 2018-11-29 22:17    [W:3.670 / U:0.568 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site