lkml.org 
[lkml]   [2018]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/4] x86/mm/cpa: Fix cpa_flush_array()
From
Date
> +void __cpa_flush_array(void *data)
> {
> - unsigned int i, level;
> + struct cpa_data *cpa = data;
> + unsigned int i;
>
> - if (__cpa_flush_range(baddr, numpages, cache))
> + for (i = 0; i < cpa->numpages; i++)
> + __flush_tlb_one_kernel(__cpa_addr(cpa, i));
> +}

While I guess it won't _hurt_ anything, we do have cases where
__cpa_addr() can return 0. So, won't this be flushing virtual address
0x0 unnecessarily for those?

\
 
 \ /
  Last update: 2018-11-30 18:44    [W:0.118 / U:15.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site