lkml.org 
[lkml]   [2018]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] dax: Fix Xarray conversion of dax_unlock_mapping_entry()
On Fri, Nov 30, 2018 at 07:54:49AM -0800, Dan Williams wrote:
> Looks good to me, although can we make that cookie an actual type? I
> think it's mostly ok to pass around (void *) for 'entry' inside of
> fs/dax.c, but once an entry leaves that file I'd like it to have an
> explicit type to catch people that might accidentally pass a (struct
> page *) to the unlock routine.

That's a really good idea. Something like this?

typedef struct {
void *v;
} dax_entry_t;

I could see us making good use of that within dax.c.

\
 
 \ /
  Last update: 2018-11-30 17:25    [W:0.061 / U:0.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site