lkml.org 
[lkml]   [2018]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESEND PATCH v3 2/2] PCI: uniphier: Add UniPhier PCIe host controller support
On Tue, Nov 20, 2018 at 09:15:31PM +0900, Kunihiko Hayashi wrote:

[...]

> > > +static int uniphier_pcie_link_up(struct dw_pcie *pci)
> >
> > This function returns a bool value, make it return a bool.
>
> This function is registered in struct dw_pcie_ops.link_up, that is defined
> in pcie-designware.h as follows:
>
> int (*link_up)(struct dw_pcie *pcie);
>
> Changing the return type of this function makes type mismatch,
> so I think it's difficult to change it.

You are right, it is fine.

Thanks,
Lorenzo

\
 
 \ /
  Last update: 2018-11-23 18:51    [W:0.070 / U:0.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site