lkml.org 
[lkml]   [2018]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/3] dt-bindings: mfd: atmel-usart: add DMA bindings for SPI mode
From
Date
On Wed, 2018-11-21 at 10:41 -0600, Rob Herring wrote:
> On Wed, Nov 21, 2018 at 5:29 AM Radu Pirea <radu_nicolae.pirea@upb.ro
> > wrote:
> > The bindings for DMA are now common for both drivers of the USART
> > IP.
> >
> > The node given as an example for USART in SPI mode has been updated
> > in
> > order to include DMA bindings.
> >
> > Signed-off-by: Radu Pirea <radu_nicolae.pirea@upb.ro>
> > ---
> > .../devicetree/bindings/mfd/atmel-usart.txt | 15 ++++++++++-
> > ----
> > 1 file changed, 10 insertions(+), 5 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/atmel-usart.txt
> > b/Documentation/devicetree/bindings/mfd/atmel-usart.txt
> > index 7f0cd72f47d2..8ad008175343 100644
> > --- a/Documentation/devicetree/bindings/mfd/atmel-usart.txt
> > +++ b/Documentation/devicetree/bindings/mfd/atmel-usart.txt
> > @@ -17,17 +17,19 @@ Required properties for USART in SPI mode:
> > - cs-gpios: chipselects (internal cs not supported)
> > - atmel,usart-mode : Must be <AT91_USART_MODE_SPI> (found in dt-
> > bindings/mfd/at91-usart.h)
> >
> > +Optional properties in serial and SPI mode:
> > +- dma bindings for dma transfer:
> > + - dmas: DMA specifier, consisting of a phandle to DMA
> > controller node,
> > + memory peripheral interface and USART DMA channel
> > ID, FIFO configuration.
> > + Refer to dma.txt and atmel-dma.txt for details.
> > + - dma-names: "rx" for RX channel, "tx" for TX channel.
> > + dma-names = "tx", "rx";
>
> The dma-names should have a defined order.

Thanks Rob.
I will specify in bindings a fixed order for dmas and dma-names.

>
> Rob

\
 
 \ /
  Last update: 2018-11-23 17:08    [W:0.069 / U:0.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site