lkml.org 
[lkml]   [2018]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] drivers/scsi/fnic/fnic_trace.c: Use vzalloc
On Wed, Nov 14, 2018 at 10:24 PM Sabyasachi Gupta
<sabyasachi.linux@gmail.com> wrote:
>
> Replaced vmalloc + memset with vzalloc
>
> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>

Any comment on this patch?

> ---
> v2: Removed additional braces
>
> drivers/scsi/fnic/fnic_trace.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/fnic/fnic_trace.c b/drivers/scsi/fnic/fnic_trace.c
> index 8271785..bf0fd2a 100644
> --- a/drivers/scsi/fnic/fnic_trace.c
> +++ b/drivers/scsi/fnic/fnic_trace.c
> @@ -468,14 +468,13 @@ int fnic_trace_buf_init(void)
> fnic_max_trace_entries = (trace_max_pages * PAGE_SIZE)/
> FNIC_ENTRY_SIZE_BYTES;
>
> - fnic_trace_buf_p = (unsigned long)vmalloc((trace_max_pages * PAGE_SIZE));
> + fnic_trace_buf_p = (unsigned long)vzalloc(trace_max_pages * PAGE_SIZE);
> if (!fnic_trace_buf_p) {
> printk(KERN_ERR PFX "Failed to allocate memory "
> "for fnic_trace_buf_p\n");
> err = -ENOMEM;
> goto err_fnic_trace_buf_init;
> }
> - memset((void *)fnic_trace_buf_p, 0, (trace_max_pages * PAGE_SIZE));
>
> fnic_trace_entries.page_offset =
> vmalloc(array_size(fnic_max_trace_entries,
> --
> 2.7.4
>

\
 
 \ /
  Last update: 2018-11-23 15:44    [W:0.060 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site