lkml.org 
[lkml]   [2018]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject答复: [PATCH] fs/xfs: fix f ffree value for statfs when project quota is set(Internet ma il)
Date
We set xfs project quota with overlayfs for docker container. When I enter into the container and run the command 'df -ih', the 'IFree' and 'IUsed' are uncorrect:

#df -ih
Filesystem Inodes IUsed IFree IUse% Mounted on
overlay 1000 -235M 235M - /

So I want to fix this flaw, and this is very meaningful for our applications.
Ye

>
> On Thu, Nov 22, 2018 at 01:28:04PM +0000, dbyin(尹烨) wrote:
> > When project is set, we should use inode limit minus the used count
> >
> > Signed-off-by: Ye Yin <dbyin@tencent.com>
>
> This makes sense to me, but ... it's been broken like this since 2006.
> Is there a reason why (someone named Glen) wrote it this way?
>
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> --D
>
> > ---
> > fs/xfs/xfs_qm_bhv.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/xfs/xfs_qm_bhv.c b/fs/xfs/xfs_qm_bhv.c index
> > 73a1d77ec187..3091e4bc04ef 100644
> > --- a/fs/xfs/xfs_qm_bhv.c
> > +++ b/fs/xfs/xfs_qm_bhv.c
> > @@ -40,7 +40,7 @@ xfs_fill_statvfs_from_dquot(
> > statp->f_files = limit;
> > statp->f_ffree =
> > (statp->f_files > dqp->q_res_icount) ?
> > - (statp->f_ffree - dqp->q_res_icount) : 0;
> > + (statp->f_files - dqp->q_res_icount) : 0;
> > }
> > }
> >
> > --
> > 2.16.2

\
 
 \ /
  Last update: 2018-11-23 03:10    [W:0.052 / U:2.608 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site