lkml.org 
[lkml]   [2018]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 20/24] x86/speculation: Split out TIF update
On Thu, 22 Nov 2018, Ingo Molnar wrote:
> * Thomas Gleixner <tglx@linutronix.de> wrote:
>
> Had to read this twice, because the comment and the code are both correct
> but deal with the inverse case. This might have helped:
>
> /*
> * Immediately update the speculation MSRs on the current task,
> * but for non-current tasks delay setting the CPU mitigation
> * until it is scheduled next.
> */
> if (tsk == current && update)
> speculation_ctrl_update_current();
>
> But can the target task ever be non-current here? I don't think so: the
> two callers are prctl and seccomp, and both are passing in the current
> task pointer.

See te other mail. Yes, seccomp passes non current task pointers. Will
update the comment.

Thanks,

tglx

\
 
 \ /
  Last update: 2018-11-23 00:05    [W:0.151 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site