[lkml]   [2018]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] mmc: meson-mx-sdio: check devm_kasprintf for failure
On Thu, Nov 22, 2018 at 10:41 AM Nicholas Mc Guire <> wrote:
> devm_kasprintf() may return NULL on failure of internal allocation thus
> the assignments to are not safe if not checked. On error
> meson_mx_mmc_register_clks() returns negative values so -ENOMEM in the
> (unlikely) failure case of devm_kasprintf() should be fine here.
> Signed-off-by: Nicholas Mc Guire <>
> Fixes: ed80a13bb4c4 ("mmc: meson-mx-sdio: Add a driver for the Amlogic Meson8 and Meson8b SoCs")
Acked-by: Martin Blumenstingl <>

thank you for the patch!
I tested the non-error case on my Odroid-C1 and it still works fine.


 \ /
  Last update: 2018-11-22 22:46    [W:0.048 / U:0.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site