lkml.org 
[lkml]   [2018]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/8] pstore: Do not use crash buffer for decompression
On Wed, Nov 14, 2018 at 01:56:09AM -0600, Kees Cook wrote:
> On Fri, Nov 2, 2018 at 1:24 PM, Joel Fernandes <joel@joelfernandes.org> wrote:
> > On Thu, Nov 01, 2018 at 04:51:54PM -0700, Kees Cook wrote:
> >> static void decompress_record(struct pstore_record *record)
> >> {
> >> + int ret;
> >> int unzipped_len;
> >
> > nit: We could get rid of the unzipped_len variable now I think.
>
> I didn't follow this -- it gets used quite a bit. I don't see a clean
> way to remove it?

You are right. Sorry I missed that crpyto_comp_decompress actually uses it.

thanks,

- Joel

\
 
 \ /
  Last update: 2018-11-20 22:44    [W:0.070 / U:66.484 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site