lkml.org 
[lkml]   [2018]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 3/5] mips: remove syscall table entries
On Mon, Nov 19, 2018 at 11:29 PM Paul Burton <paul.burton@mips.com> wrote:
>
> Hi Firoz,
>
> On Thu, Nov 15, 2018 at 11:44:19AM +0530, Firoz Khan wrote:
> > diff --git a/arch/mips/kernel/scall32-o32.S b/arch/mips/kernel/scall32-o32.S
> > index a9b895f..4eee437 100644
> > --- a/arch/mips/kernel/scall32-o32.S
> > +++ b/arch/mips/kernel/scall32-o32.S
> > @@ -208,6 +208,18 @@ einval: li v0, -ENOSYS
> > jr ra
> > END(sys_syscall)
> >
> > +#ifdef CONFIG_MIPS_MT_FPAFF
> > + /*
> > + * For FPU affinity scheduling on MIPS MT processors, we need to
> > + * intercept sys_sched_xxxaffinity() calls until we get a proper hook
> > + * in kernel/sched/core.c. Considered only temporary we only support
> > + * these hooks for the 32-bit kernel - there is no MIPS64 MT processor
> > + * atm.
> > + */
> > +#define mipsmt_sys_sched_setaffinity sys_sched_setaffinity
> > +#define mipsmt_sys_sched_getaffinity sys_sched_getaffinity
>
> Is this backwards? ie. should it be:
>
> #define sys_sched_setaffinity mipsmt_sys_sched_setaffinity
> #define sys_sched_getaffinity mipsmt_sys_sched_getaffinity
>
> ?
>
> I don't see how the mipsmt_* functions will ever be used after this
> patch.

Good catch!

> > - * atm.
> > - */
> > - PTR mipsmt_sys_sched_setaffinity
> > - PTR mipsmt_sys_sched_getaffinity
> > -#else
> > PTR sys_sched_setaffinity
> > PTR sys_sched_getaffinity /* 4240 */
> > -#endif /* CONFIG_MIPS_MT_FPAFF */
> > PTR sys_io_setup

My guess would be that he removed the wrong lines here instead,
and the first half was intentional.

Arnd

\
 
 \ /
  Last update: 2018-11-20 11:54    [W:0.060 / U:7.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site