lkml.org 
[lkml]   [2018]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Documentation: update path-lookup.md for parallel lookups
On Mon, 19 Nov 2018 11:55:46 +1100
NeilBrown <neilb@suse.com> wrote:

> Since this document was written, i_mutex has been replace with
> i_rwsem, and shared locks are utilized to allow lookups in the one
> directory to happen in parallel.
>
> So replace i_mutex with i_rwsem, and explain how this is used for
> parallel lookups.
>
> Signed-off-by: NeilBrown <neilb@suse.com>

I've applied this, thanks. I do have a couple of small comments, though...

#1: what are the chances of getting this document converted to RST and
tied into our documentation tree?

#2: ...

> Just FYI
>
> $ git grep -w i_mutex | wc -l
> 262
>
> it was 276 before this patch... so a small improvement.
>
> NeilBrown
>
>
> Documentation/filesystems/path-lookup.md | 85 ++++++++++++++++++------
> 1 file changed, 66 insertions(+), 19 deletions(-)
>
> diff --git a/Documentation/filesystems/path-lookup.md b/Documentation/filesystems/path-lookup.md
> index e2edd45c4bc0..06151b178f80 100644
> --- a/Documentation/filesystems/path-lookup.md
> +++ b/Documentation/filesystems/path-lookup.md
> @@ -12,6 +12,10 @@ This write-up is based on three articles published at lwn.net:
> - <https://lwn.net/Articles/650786/> A walk among the symlinks
>
> Written by Neil Brown with help from Al Viro and Jon Corbet.
> +It has subsequently been updated to reflect changes in the kernel
> +including:
> +
> +- per-directory parallel name lookup.

I'm unconvinced about the value of putting changelogs into the docs
themselves; that's what we keep git around for. (I *do* think there's
some value of having something in a document giving a hint of how current
it is, though).

Thanks,

jon

\
 
 \ /
  Last update: 2018-11-20 17:39    [W:0.115 / U:7.836 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site