[lkml]   [2018]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH V10 09/19] block: introduce bio_bvecs()
On Mon, Nov 19, 2018 at 04:49:27PM -0800, Sagi Grimberg wrote:
>> The only user in your final tree seems to be the loop driver, and
>> even that one only uses the helper for read/write bios.
>> I think something like this would be much simpler in the end:
> The recently submitted nvme-tcp host driver should also be a user
> of this. Does it make sense to keep it as a helper then?

I did take a brief look at the code, and I really don't understand
why the heck it even deals with bios to start with. Like all the
other nvme transports it is a blk-mq driver and should iterate
over segments in a request and more or less ignore bios. Something
is horribly wrong in the design.

 \ /
  Last update: 2018-11-20 17:17    [W:0.192 / U:1.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site