lkml.org 
[lkml]   [2018]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [git pull] mount API series
On Thu, Nov 01, 2018 at 11:59:23PM +0000, David Howells wrote:

> (*) mount-api-core. These are the internal-only patches that add the
> fs_context, the legacy wrapper and the security hooks and make certain
> filesystems make use of it.

FWIW, while rereading that series I'd spotted something very odd in erofs.
It's orthogonal to everything else, but just to make sure it doesn't get
lost:
* sbi->dev_name thing in erofs is used only for debugging printks,
basically. Just use sb->s_id[] and be done with that.
* dump struct erofs_mount_private - you don't need dev_name in
your erofs_fill_super(). Just use mount_bdev() in usual fashion.
* what the hell are you doing with ->s_root??? Why would you
possibly want it hashed and what kind of dcache lookup could find it?
That d_rehash() looks deeply confused; what are you trying to do there?

\
 
 \ /
  Last update: 2018-11-02 05:07    [W:0.482 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site