lkml.org 
[lkml]   [2018]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] x86/fpu: Disable BH while while loading FPU registers in __fpu__restore_sig()
From
Date
On 11/19/18 3:41 AM, Sebastian Andrzej Siewior wrote:
> On 2018-11-12 09:48:08 [-0800], Dave Hansen wrote:
>> On 11/12/18 7:56 AM, Sebastian Andrzej Siewior wrote:
>>> Use local_bh_disable() around the restore sequence to avoid the race. BH
>>> needs to be disabled because BH is allowed to run (even with preemption
>>> disabled) and might invoke kernel_fpu_begin().
>> FWIW, that would make nice comment fodder for the local_bh_disable().
>> I'd much rather run into it there than in a changelog.
> Hmm. Should I really resent a v2 of this with the additional comment?
> This patch should go stable to the fix the bug and at the end of this
> series I remove/replace this hunk anyway.
> I can do either way, just wanted to check first.

Does the local_bh_disable() itself survive?

\
 
 \ /
  Last update: 2018-11-19 16:05    [W:0.093 / U:5.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site