lkml.org 
[lkml]   [2018]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv4 5/6] drm/omap: add framedone interrupt support
Hi,

On Sat, Nov 17, 2018 at 10:08:40PM +0100, Pavel Machek wrote:
> > This prepares framedone interrupt handling for
> > manual display update support.
> >
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
>
> Acked-by: Pavel Machek <pavel@ucw.cz>

Thanks.

> > @@ -217,6 +239,9 @@ static irqreturn_t omap_irq_handler(int irq, void *arg)
> >
> > if (irqstatus & priv->dispc_ops->mgr_get_sync_lost_irq(priv->dispc, channel))
> > omap_crtc_error_irq(crtc, irqstatus);
> > +
> > + if (irqstatus & priv->dispc_ops->mgr_get_framedone_irq(priv->dispc, channel))
> > + omap_crtc_framedone_irq(crtc, irqstatus);
> > }
> >
> > omap_irq_ocp_error_handler(dev, irqstatus);
>
> Will the mgr_get_framedone_irq(priv->dispc, channel) change from
> interrupt to interrupt? Would it make sense to cache result as a
> micro-organization?

Maybe. But this is the same for the the omap_crtc_error_* and the
driver is currently being restructured by Laurent. I think this can
wait for later.

-- Sebastian
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-11-19 13:06    [W:0.077 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site