lkml.org 
[lkml]   [2018]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [Letux-kernel] [PATCH RFC 4/5] gnss: sirf: add a separate supply for a lna
From
Date

> Am 18.11.2018 um 22:58 schrieb Andreas Kemnade <andreas@kemnade.info>:
>
> Devices might have a separate lna between antenna output of the gps
> chip and the antenna which might have a separate supply
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> drivers/gnss/sirf.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/drivers/gnss/sirf.c b/drivers/gnss/sirf.c
> index 6a0e5c0a2d62..f7573ca2dacd 100644
> --- a/drivers/gnss/sirf.c
> +++ b/drivers/gnss/sirf.c
> @@ -30,6 +30,7 @@ struct sirf_data {
> struct serdev_device *serdev;
> speed_t speed;
> struct regulator *vcc;
> + struct regulator *lna;
> struct gpio_desc *on_off;
> struct gpio_desc *wakeup;
> int irq;
> @@ -217,6 +218,7 @@ static int sirf_runtime_suspend(struct device *dev)
>
> if (!data->on_off)
> return regulator_disable(data->vcc);
> + regulator_disable(data->lna);
> ret = sirf_set_active(data, false);
>
> if (ret)
> @@ -245,13 +247,20 @@ static int sirf_runtime_resume(struct device *dev)
> if (ret)
> goto err_close_serdev;
> }
> +
> + ret = regulator_enable(data->lna);
> + if (ret)
> + goto err_disable_vcc;
> +
> ret = sirf_set_active(data, true);
>
> if (!ret)
> return 0;
>
> +err_disable_vcc:
> if (!data->on_off)
> regulator_disable(data->vcc);
> +
> err_close_serdev:
> serdev_device_close(data->serdev);
> return ret;
> @@ -340,6 +349,12 @@ static int sirf_probe(struct serdev_device *serdev)
> goto err_put_device;
> }
>
> + data->lna = devm_regulator_get(dev, "lna");
> + if (IS_ERR(data->lna)) {
> + ret = PTR_ERR(data->lna);
> + goto err_put_device;
> + }
> +
> data->on_off = devm_gpiod_get_optional(dev, "sirf,onoff",
> GPIOD_OUT_LOW);
> if (IS_ERR(data->on_off))
> --
> 2.11.0
>
> _______________________________________________
> http://projects.goldelico.com/p/gta04-kernel/
> Letux-kernel mailing list
> Letux-kernel@openphoenux.org
> http://lists.goldelico.com/mailman/listinfo.cgi/letux-kernel

Looks good and to do what it is designed for.

Acked-by: H. Nikolaus Schaller <hns@goldelico.com>

BR and thanks,
Nikolaus

\
 
 \ /
  Last update: 2018-11-19 09:43    [W:0.251 / U:7.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site