lkml.org 
[lkml]   [2018]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v4 6/6] pinctrl: lochnagar: Add support for the Cirrus Logic Lochnagar
On Thu, Nov 8, 2018 at 11:14 AM Charles Keepax
<ckeepax@opensource.cirrus.com> wrote:

> Lochnagar is an evaluation and development board for Cirrus
> Logic Smart CODEC and Amp devices. It allows the connection of
> most Cirrus Logic devices on mini-cards, as well as allowing
> connection of various application processor systems to provide a
> full evaluation platform. This driver supports the board
> controller chip on the Lochnagar board.
>
> Lochnagar provides many pins which can generally be used for an
> audio function such as an AIF or a PDM interface, but also as
> GPIOs.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>

This v4 version looks very good to me!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Nitpicks (fix or not, my review tag stands):

> drivers/pinctrl/cirrus/pinctrl-lochnagar.c | 1145 ++++++++++++++++++++++++++++
> drivers/pinctrl/cirrus/pinctrl-lochnagar.h | 112 +++

Why don't you just include that header file in the C file.
112 lines +/- on a 1145 line file doesn't matter.

> + priv->gpio_chip = template_chip;

I would just skip the template and just assign struct members
directly.

Bonus if you set ->label to something instance-unique as well.

Yours,
Linus Walleij

\
 
 \ /
  Last update: 2018-11-15 11:55    [W:0.116 / U:0.656 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site