lkml.org 
[lkml]   [2018]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] PCI fixes for v4.20
On Thu, Nov 15, 2018 at 10:54:18AM -0500, Konstantin Ryabitsev wrote:
> On Thu, Nov 15, 2018 at 09:03:21AM -0600, Bjorn Helgaas wrote:
> > > You didn't really do anything wrong. In *general* I prefer to see
> > > public URLs if they are sent to public lists, so if you're cc'ing
> > > something to LKML, I would generally expect the pull request to have a
> > > public URL like https://git.kernel.org/ instead of a private ssh:// URL
> > > that is only accessible to people with a kernel.org account.
> > >
> > > That's basically all there is to it. It doesn't *really* matter, since
> > > Linus is the one who will be merging the actual pull request, and he
> > > certainly has access to internal ssh:// URLs. However, in case someone
> > > else was interested in reviewing the pull request, it would be more
> > > friendly to have a public URL for them.
> >
> > OK, I think I'll remove the insteadOf chunk from my .gitconfig. Should
> > https://korg.wiki.kernel.org/userdoc/gitolite be updated to remove or
> > expand that recommendation? The only reason I added insteadOf in the first
> > place was because it sounded like a security improvement.
>
> It is. Does adding the insteadOf rules result in ssh:// URLs when using
> git-request-pull? I didn't expect that it would.

Yep, it seems to for me. Maybe I'm doing something else weird, because I
don't see many other pull requests with ssh:// URLs.

\
 
 \ /
  Last update: 2018-11-15 18:28    [W:0.057 / U:7.760 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site