[lkml]   [2018]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 02/24] leds: core: Add support for composing LED class device names
On Sun, Nov 11, 2018 at 1:03 PM Pavel Machek <> wrote:

> > -"devicename:colour:function"
> > +"colour:function"
> I don't think we want to do it in all cases.
> So, on my cellphone seeing lp5523:green:led is indeed not useful.
> But on notebook with usb keyboard attached, you need to keep the
> devicename to be able to distinguish capslock on internal keyboard and
> capslock on first USB keyboard and capslock on second USB keyboard.

I agree with Pavel.

I ran into this when connecting two identical keyboards to the
same machine. The driver worked fine up until it tries
to create two sysfs entries with the same name for capslock.

In this case I suggest "serialnumber:color:capslock" and

The important point is the string must be unique for each
plugged device.

Linus Walleij

 \ /
  Last update: 2018-11-12 22:24    [W:0.217 / U:0.776 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site