lkml.org 
[lkml]   [2018]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC] hist lookups
On Sun, Nov 11, 2018 at 08:41:32PM +0100, Jiri Olsa wrote:
> On Thu, Nov 08, 2018 at 05:07:21PM -0800, David Miller wrote:
> > From: Jiri Olsa <jolsa@redhat.com>
> > Date: Thu, 8 Nov 2018 08:13:03 +0100
> >
> > > we could separated fork/mmaps to separate dummy event map, or just
> > > parse them out in the read thread and create special queue for them
> > > and drop just samples in case we are behind
> >
> > What you say at the end here is basically what I am proposing.
> >
> > Perf dequeues events from mmap ring as fast as possible.
> >
> > Perf has two internal queues, high priority and low priority.
> >
> > High priority events are never dropped.
> >
> > Low priority events are dropped on overload, oldest first.
>
> I added the dropping logic, it's simple so far..
>
> the processing thread will drop (not process) samples
> which gets behind the latest event time more then
> the 'refresh rate' seconds
>
> adding separate queues for samples and other events is
> possible, but it looks like the above simple solution
> could be ok for now

I pushed it to my perf/fixes branch

jirka

\
 
 \ /
  Last update: 2018-11-11 20:42    [W:0.192 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site