lkml.org 
[lkml]   [2018]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/5] fpga: dfl-fme-region: Use platform_get_drvdata()
On Mon, Nov 12, 2018 at 09:46:53AM -0600, Alan Tull wrote:
> On Sun, Sep 30, 2018 at 10:48 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
>
> Hi Greg,
>
> >
> > On Wed, Sep 12, 2018 at 09:43:27AM -0500, Alan Tull wrote:
> > > From: Moritz Fischer <mdf@kernel.org>
> > >
> > > Use platform_get_drvdata() in remove() function of
> > > the platform driver rather than dev_get_drvdata()
> > > to match the platform_set_drvdata in the probe().
> > >
> > > Signed-off-by: Moritz Fischer <mdf@kernel.org>
> > > Acked-by: Alan Tull <atull@kernel.org>
> > > ---
> > > drivers/fpga/dfl-fme-region.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/fpga/dfl-fme-region.c b/drivers/fpga/dfl-fme-region.c
> > > index 51a5ac2..3fa0de2 100644
> > > --- a/drivers/fpga/dfl-fme-region.c
> > > +++ b/drivers/fpga/dfl-fme-region.c
> > > @@ -66,7 +66,7 @@ static int fme_region_probe(struct platform_device *pdev)
> > >
> > > static int fme_region_remove(struct platform_device *pdev)
> > > {
> > > - struct fpga_region *region = dev_get_drvdata(&pdev->dev);
> > > + struct fpga_region *region = platform_get_drvdata(pdev);
> >
> > This is nice, but not a bugfix. I'll wait for 4.20-rc1 for this patch.
>
> Could you take patch 4/5 and 5/5? They didn't make it into a 4.20 rc yet.

Can you resend them please? I don't see either of these in my queue
anywhere.

thanks,

greg k-h

\
 
 \ /
  Last update: 2018-11-12 19:03    [W:0.052 / U:1.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site