lkml.org 
[lkml]   [2018]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] x86/fpu: Disable BH while while loading FPU registers in __fpu__restore_sig()
From
Date
On 11/12/18 7:56 AM, Sebastian Andrzej Siewior wrote:
> Use local_bh_disable() around the restore sequence to avoid the race. BH
> needs to be disabled because BH is allowed to run (even with preemption
> disabled) and might invoke kernel_fpu_begin().

FWIW, that would make nice comment fodder for the local_bh_disable().
I'd much rather run into it there than in a changelog.


\
 
 \ /
  Last update: 2018-11-12 18:48    [W:0.106 / U:12.828 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site