lkml.org 
[lkml]   [2018]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 05/24] dt-bindings: sc27xx-blt: Add function and color properties
From
Date
Hi Pavel.

On 11/11/2018 03:29 PM, Pavel Machek wrote:
> On Tue 2018-11-06 23:07:13, Jacek Anaszewski wrote:
>> Refer to new "function" and "color" properties and mark "label"
>> as deprecated.
>>
>> Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
>> Cc: Xiaotong Lu <xiaotong.lu@spreadtrum.com>
>> Cc: Baolin Wang <baolin.wang@linaro.org>
>
> Don't you want to keep both color and label? New dts on old kernel
> should still work...?
>
> Ok, I see these are only examples....

Right, this is only an example, and we'd rather want to encourage
people to switch to using new LED naming.

>> @@ -25,17 +27,17 @@ led-controller@200 {
>> reg = <0x200>;
>>
>> led@0 {
>> - label = "red";
>> + color = "red";
>> reg = <0x0>;
>> };
>>
>> led@1 {
>> - label = "green";
>> + color = "green";
>> reg = <0x1>;
>> };
>>
>> led@2 {
>> - label = "blue";
>> + color = "blue";
>> reg = <0x2>;
>> };
>> };
>

--
Best regards,
Jacek Anaszewski

\
 
 \ /
  Last update: 2018-11-11 21:04    [W:0.071 / U:0.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site