lkml.org 
[lkml]   [2018]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC/RFT][PATCH v5] cpuidle: New timer events oriented governor for tickless systems
On Thu, Nov 08, 2018 at 06:25:07PM +0100, Rafael J. Wysocki wrote:
> +/*
> + * The SPIKE value is added to metrics when they grow and the DECAY_SHIFT value
> + * is used for decreasing metrics on a regular basis.
> + */
> +#define SPIKE 1024
> +#define DECAY_SHIFT 3

> + if (idx_timer >= 0) {
> + unsigned int hits = cpu_data->states[idx_timer].hits;
> + unsigned int misses = cpu_data->states[idx_timer].misses;
> +
> + hits -= hits >> DECAY_SHIFT;
> + misses -= misses >> DECAY_SHIFT;
> +
> + if (idx_timer > idx_hit) {
> + misses += SPIKE;
> + if (idx_hit >= 0)
> + cpu_data->states[idx_hit].early_hits += SPIKE;
> + } else {
> + hits += SPIKE;
> + }
> +
> + cpu_data->states[idx_timer].misses = misses;
> + cpu_data->states[idx_timer].hits = hits;
> + }

That's a pulse-density-modulator, with a signal bound of:

1024 == x/8 -> x := 8192

Anyway; I would suggest s/SPIKE/PULSE/ because of that.

\
 
 \ /
  Last update: 2018-11-11 16:20    [W:0.144 / U:1.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site