lkml.org 
[lkml]   [2018]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] video: fbdev: remove redundant 'default n' from Kconfig-s
From
Date
On 10/8/18 8:40 AM, Bartlomiej Zolnierkiewicz wrote:
> 'default n' is the default value for any bool or tristate Kconfig
> setting so there is no need to write it explicitly.
>
> Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO
> is not set' for visible symbols") the Kconfig behavior is the same
> regardless of 'default n' being present or not:
>
> ...
> One side effect of (and the main motivation for) this change is making
> the following two definitions behave exactly the same:
>
> config FOO
> bool
>
> config FOO
> bool
> default n

config FOO
def_bool n

is a good substitute, especially for non-prompt symbols. (IMHO)

> With this change, neither of these will generate a
> '# CONFIG_FOO is not set' line (assuming FOO isn't selected/implied).
> That might make it clearer to people that a bare 'default n' is
> redundant.
> ...
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

> ---
> drivers/video/fbdev/Kconfig | 28 ---------------------------
> drivers/video/fbdev/mmp/hw/Kconfig | 1
> drivers/video/fbdev/mmp/panel/Kconfig | 1
> drivers/video/fbdev/omap2/omapfb/dss/Kconfig | 7 ------
> 4 files changed, 37 deletions(-)

thanks.
--
~Randy

\
 
 \ /
  Last update: 2018-10-08 17:54    [W:0.048 / U:5.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site