lkml.org 
[lkml]   [2018]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/3] lib/vsprintf: Prepare for more general use of ptr_to_id()
Hi Andy,

On Mon, Oct 8, 2018 at 4:25 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On Mon, Oct 08, 2018 at 01:05:02PM +0200, Geert Uytterhoeven wrote:
> > - Make the ptr argument const, to avoid adding casts in future
> > callers,
>
> > - Add a forward declaration, to avoid moving large blocks of code.
>
> How big it would be? ptr_to_id() itself plus...

... all the randomization helpers.
And ptr_to_id() needs pointer_string(), string(), widen_string(), number(),
and move_right().

118 insertions(+), 120 deletions(-)

Is that acceptable?

> > +static char *ptr_to_id(char *buf, char *end, const void *ptr,
> > + struct printf_spec spec);
-
Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

\
 
 \ /
  Last update: 2018-10-08 16:38    [W:0.076 / U:4.784 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site