lkml.org 
[lkml]   [2018]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH V3 2/13] KVM/MMU: Add tlb flush with range helper function
Hi Paolo:
Thanks for your review. Sorry for later response due to holiday.

On Mon, Oct 1, 2018 at 11:26 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 27/09/2018 05:48, Tianyu Lan wrote:
> > +
> > + if (range && kvm_x86_ops->tlb_remote_flush_with_range) {
> > + /*
> > + * Read tlbs_dirty before flushing tlbs in order
> > + * to track dirty tlbs during flushing.
> > + */
> > + long dirty_count = smp_load_acquire(&kvm->tlbs_dirty);
> > +
> > + ret = kvm_x86_ops->tlb_remote_flush_with_range(kvm, range);
> > + cmpxchg(&kvm->tlbs_dirty, dirty_count, 0);
>
> This is wrong, because it's not the entire TLB that is flushed. So you
> cannot do the cmpxchg here.

Yes, nice catch. Will update in the next version.


--
Best regards
Tianyu Lan

\
 
 \ /
  Last update: 2018-10-08 11:18    [W:0.072 / U:1.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site