lkml.org 
[lkml]   [2018]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [v2, 1/5] net: dpaa2: move DPAA2 PTP driver out of staging/
Date
Let me just add an additional patch in v3.
I had sent the new v3 patch-set out. Please help to review.

Thanks a lot.

Best regards,
Yangbo Lu

> -----Original Message-----
> From: Y.b. Lu
> Sent: Monday, October 8, 2018 11:11 AM
> To: 'Andrew Lunn' <andrew@lunn.ch>; Ioana Ciocoi Radulescu
> <ruxandra.radulescu@nxp.com>
> Cc: linux-kernel@vger.kernel.org; devel@driverdev.osuosl.org;
> netdev@vger.kernel.org; Richard Cochran <richardcochran@gmail.com>;
> David S . Miller <davem@davemloft.net>; Ioana Ciocoi Radulescu
> <ruxandra.radulescu@nxp.com>; Greg Kroah-Hartman
> <gregkh@linuxfoundation.org>
> Subject: RE: [v2, 1/5] net: dpaa2: move DPAA2 PTP driver out of staging/
>
> Hi Andrew,
>
> Sorry for late. Just come back from holiday.
>
> Hi Ioana,
>
> Could you generate an additional patch for dpaa2_eth to address Andrew's
> comments?
> There was also a warning when checked patch. FSL_DPAA2_ETH needed more
> description.
>
> WARNING: please write a paragraph that describes the config symbol fully
> #66: FILE: drivers/net/ethernet/freescale/dpaa2/Kconfig:1:
> +config FSL_DPAA2_ETH
>
> Thanks a lot.
>
> Best regards,
> Yangbo Lu
>
> > -----Original Message-----
> > From: Andrew Lunn <andrew@lunn.ch>
> > Sent: Sunday, September 30, 2018 3:46 AM
> > To: Y.b. Lu <yangbo.lu@nxp.com>
> > Cc: linux-kernel@vger.kernel.org; devel@driverdev.osuosl.org;
> > netdev@vger.kernel.org; Richard Cochran <richardcochran@gmail.com>;
> > David S . Miller <davem@davemloft.net>; Ioana Ciocoi Radulescu
> > <ruxandra.radulescu@nxp.com>; Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org>
> > Subject: Re: [v2, 1/5] net: dpaa2: move DPAA2 PTP driver out of
> > staging/
> >
> > > +++ b/drivers/net/ethernet/freescale/dpaa2/Kconfig
> > > @@ -0,0 +1,15 @@
> > > +config FSL_DPAA2_ETH
> > > + tristate "Freescale DPAA2 Ethernet"
> > > + depends on FSL_MC_BUS && FSL_MC_DPIO
> >
> > Could you add in here COMPILE_TEST?
> >
> > > + depends on NETDEVICES && ETHERNET
> >
> > With the move out of staging, i don't think these two are required.
> >
> > Andrew

\
 
 \ /
  Last update: 2018-10-08 09:52    [W:0.094 / U:1.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site