lkml.org 
[lkml]   [2018]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 030/113] media: tm6000: add error handling for dvb_register_adapter
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Zhouyang Jia <jiazhouyang09@gmail.com>

    [ Upstream commit e95d7c6eb94c634852eaa5ff4caf3db05b5d2e86 ]

    When dvb_register_adapter fails, the lack of error-handling code may
    cause unexpected results.

    This patch adds error-handling code after calling dvb_register_adapter.

    Signed-off-by: Zhouyang Jia <jiazhouyang09@gmail.com>
    [hans.verkuil@cisco.com: use pr_err and fix typo: adater -> adapter]
    Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/media/usb/tm6000/tm6000-dvb.c | 5 +++++
    1 file changed, 5 insertions(+)

    --- a/drivers/media/usb/tm6000/tm6000-dvb.c
    +++ b/drivers/media/usb/tm6000/tm6000-dvb.c
    @@ -275,6 +275,11 @@ static int register_dvb(struct tm6000_co

    ret = dvb_register_adapter(&dvb->adapter, "Trident TVMaster 6000 DVB-T",
    THIS_MODULE, &dev->udev->dev, adapter_nr);
    + if (ret < 0) {
    + pr_err("tm6000: couldn't register the adapter!\n");
    + goto err;
    + }
    +
    dvb->adapter.priv = dev;

    if (dvb->frontend) {

    \
     
     \ /
      Last update: 2018-10-08 21:20    [W:3.136 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site