lkml.org 
[lkml]   [2018]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/22] KEYS: Provide software public key query function
On Fri, 5 Oct 2018, David Howells wrote:

> James Morris <jmorris@namei.org> wrote:
>
> > > + if (strcmp(encoding, "raw") == 0) {
> > > + strcpy(alg_name, pkey->pkey_algo);
> > > + return 0;
> > > + }
> >
> > Can encoding here also be NULL to indicate raw? per patch 01:
>
> Ummm... By the letter of the documentation, yes, though in practice it isn't
> (it is defaulted to "raw") in the keyctl interface. I wonder if it would be
> better to require it to say "raw" and never be NULL.

Probably.

--
James Morris
<jmorris@namei.org>

\
 
 \ /
  Last update: 2018-10-05 18:28    [W:0.135 / U:2.940 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site