| From | David Howells <> | Subject | Re: [PATCH 05/22] KEYS: Provide software public key query function | Date | Fri, 05 Oct 2018 16:51:42 +0100 |
| |
James Morris <jmorris@namei.org> wrote:
> > + if (strcmp(encoding, "raw") == 0) { > > + strcpy(alg_name, pkey->pkey_algo); > > + return 0; > > + } > > Can encoding here also be NULL to indicate raw? per patch 01:
Ummm... By the letter of the documentation, yes, though in practice it isn't (it is defaulted to "raw") in the keyctl interface. I wonder if it would be better to require it to say "raw" and never be NULL.
David
|