lkml.org 
[lkml]   [2018]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subjectset_cpus_allowed_ptr() usage in FREESCALE CAAM
Hi,

this block:
|int caam_qi_shutdown(struct device *qidev)
| {
| struct cpumask old_cpumask = current->cpus_allowed;

| /*
| * QMan driver requires CGRs to be deleted from same CPU from where they
| * were instantiated. Hence we get the module removal execute from the
| * same CPU from where it was originally inserted.
| */
| set_cpus_allowed_ptr(current, get_cpu_mask(mod_init_cpu));

| /* Now that we're done with the CGRs, restore the cpus allowed mask */
| set_cpus_allowed_ptr(current, &old_cpumask);

in drivers/crypto/caam/qi.c needs to go. I saw it twice in the driver.
set_cpus_allowed_ptr() is not intended for this kind of thing.

What you want is to use work_on_cpu_safe() instead. It takes also a CPU
as an argument. You need to check the error code of the function if it
worked because the CPU may have gone offline. This functions also
ensures that the CPU does not vanish in the middle of the work.
Also please check the error code in both cases of the function because
it may fail if the CPU is not online.

Sebastian

\
 
 \ /
  Last update: 2018-10-05 14:55    [W:0.126 / U:5.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site